Attention is currently required from: NyeonWoo Kim, Shuo Liu.
Hello Jérémy Compostella, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87181?usp=email
to look at the new patch set (#2).
Change subject: src/arch/x86/c_start: Delete duplicated code masking stack pointer ......................................................................
src/arch/x86/c_start: Delete duplicated code masking stack pointer
I found duplicated code masking stack pointer.
So, i'd like to remove the duplicate for refactoring :-).
This is my build output of c_start.o, before vs after modifying. before modifying ... 44: f3 ab rep stos %eax,%es:(%edi) 46: bc 00 00 00 00 mov $0x0,%esp 4b: 83 e4 f0 and $0xfffffff0,%esp 4e: b0 6e mov $0x6e,%al 50: e6 80 out %al,$0x80 52: 83 e4 f0 and $0xfffffff0,%esp // deleted. 55: e8 fc ff ff ff call 56 <_start+0x56> ... after modifying ... 44: f3 ab rep stos %eax,%es:(%edi) 46: bc 00 00 00 00 mov $0x0,%esp 4b: 83 e4 f0 and $0xfffffff0,%esp 4e: b0 6e mov $0x6e,%al 50: e6 80 out %al,$0x80 52: e8 fc ff ff ff call 53 <_start+0x53> ...
P.S. it is commits which introduced duplication. 32bit : 4d75dbd1c1d 64bit : 1c4c7ad1e5a
Change-Id: I417ce90279fea4b00432e6a209f77a6dd0c0fee6 Signed-off-by: NyeonWoo Kim knw0507@naver.com --- M src/arch/x86/c_start.S 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/87181/2