Attention is currently required from: awokd@danwin1210.me, Paul Menzel, Angel Pons.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58652 )
Change subject: src/device/pci: add support for AMD_DGPU_WITHOUT_EEPROM init and OpROM loading
......................................................................
Patch Set 1:
(1 comment)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/58652/comment/627eacee_6e1b12e8
PS1, Line 754: PCI_CLASS_DISPLAY_OTHER
Delving deeper into this change, I noticed that the AMD dGPU's PCI class is assumed to be `PCI_CLASS […]
Would "binding to devices by PCI IDs" block the theoretical ability of loading a custom VBIOS on your "_with_ EEPROM" GPU without flashing it to its' memory? (useful for testing the modded VBIOSes)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d989185acb83c0987b2d7b6c6d04fb26094290
Gerrit-Change-Number: 58652
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: awokd@danwin1210.me
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: awokd@danwin1210.me
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 10:26:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment