Change in coreboot[master]: mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47501 )
Change subject: mb/google/volteer/v/volteer2: Add config for passive USB-C DB on C1 ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/47501/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47501/7//COMMIT_MSG@7 PS7, Line 7: Config for passive USB-C DB on C1
Plesae make it a statement by adding a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/47501/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/47501/3/src/mainboard/google/voltee... PS3, Line 153: VARIANT_HAS_PASSIVE_USB_DB
I don't think this is necessary. […]
Done
https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... PS2, Line 131: x04; /* port2 retimer disable */
these are in the EDS, but not available in published header files. […]
Done
https://review.coreboot.org/c/coreboot/+/47501/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47501/7/src/mainboard/google/voltee... PS7, Line 129: #if CONFIG(VARIANT_HAS_PASSIVE_USB_DB) : /* Set up port C1 for USB3 passive DB */ : if (fw_config_probe(FW_CONFIG(DB_USB, USB3_PASSIVE))) { : /* : * TGL UP3/UP4 Processor EDS vol. 2a rev. 1.2 : * section 3.6.10 : * set IOM_TYPEC_SW_CONFIGURATION_4.PORT2_HSL_ORIENTATION_OVRRD_EN : */ : cfg->TcssAuxOri |= IOM_TCSS_PORT_CTRL(1, : IOM_TCSS_ORI_NORMAL, IOM_TCSS_MUX_INTERNAL); : cfg->IomTypeCPortPadCfg[2] = GPIO_ID_TCP1_AUXP_DC; : cfg->IomTypeCPortPadCfg[3] = GPIO_ID_TCP1_AUXN_DC; : } : #endif /* VARIANT_HAS_PASSIVE_USB_DB */
suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/47501/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/47501/3/src/mainboard/google/voltee... PS3, Line 34: #define TGL_GPIO_ID_GPP_E22 0x090E0016 : #define TGL_GPIO_ID_GPP_E23 0x090E0017 :
that's a question for brandon.breitenstein@intel.com. […]
Done
https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/47501/2/src/mainboard/google/voltee... PS2, Line 34: 0x090E0016
i couldn't find any published macros to compose this value. […]
Done
-
Caveh Jalali (Code Review)