Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41853 )
Change subject: mb/google/dedede: config spk_en gpio to low by default
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41853/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41853/3//COMMIT_MSG@10
PS3, Line 10: based on use, so configure it low to save power.
Did you measure the power saving?
Yes, we are seeing a power saving of ~10mW.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070679457b06cb82633c1197b893a5d89c8b2cf0
Gerrit-Change-Number: 41853
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 10:47:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment