Jenny Tc has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31637
Change subject: mb/google/poppy/variant/atlas: change speaker IV channels ......................................................................
mb/google/poppy/variant/atlas: change speaker IV channels
Change speaker IV channels for max98373 to match with 24 bit topology firmware
BUG=b:110795132 BRANCH=none TEST=Verify playback after flashing CQ-DEPEND=*806750
Change-Id: Ib572e6ae219f899f332dcdb0661eb4eee36fc019 Signed-off-by: Jenny TC jenny.tc@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31637/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 5b49884..d653993 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -310,16 +310,16 @@ device pci 19.1 off end # I2C #5 device pci 19.2 on chip drivers/i2c/max98373 - register "vmon_slot_no" = "4" - register "imon_slot_no" = "5" + register "vmon_slot_no" = "1" + register "imon_slot_no" = "0" register "uid" = "0" register "desc" = ""RIGHT SPEAKER AMP"" register "name" = ""MAXR"" device i2c 31 on end end chip drivers/i2c/max98373 - register "vmon_slot_no" = "6" - register "imon_slot_no" = "7" + register "vmon_slot_no" = "3" + register "imon_slot_no" = "2" register "uid" = "1" register "desc" = ""LEFT SPEAKER AMP"" register "name" = ""MAXL""
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31637
to look at the new patch set (#2).
Change subject: mb/google/poppy/variant/atlas: change speaker IV channels ......................................................................
mb/google/poppy/variant/atlas: change speaker IV channels
Change speaker IV channels for max98373 to match with 24 bit topology firmware
BUG=b:110795132 BRANCH=none TEST=Verify playback after flashing CQ-DEPEND=CL:1547644
Change-Id: Ib572e6ae219f899f332dcdb0661eb4eee36fc019 Signed-off-by: Jenny TC jenny.tc@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31637/2
Jenny Tc has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31637 )
Change subject: mb/google/poppy/variant/atlas: change speaker IV channels ......................................................................
Abandoned
Squashed into soc CL (https://review.coreboot.org/c/coreboot/+/31635)