Change in ...coreboot[master]: Kconfig: Unify power-after-failure options - coreboot-gerrit

21 Nov 2018


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29680 )
Change subject: Kconfig: Unify power-after-failure options
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmcli... 
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/#/c/29680/3/src/soc/intel/common/block/pmc/pmcli... 
PS3, Line 590: 	return CONFIG_MAINBOARD_POWER_FAILURE_STATE;
...
we are ignoring "Keep Previous State" options ?
`config MAINBOARD_POWER_FAILURE_STATE` is an `int` taking either 0, 1 or 2.
Just what this function used to return.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61259f864c8a8cfc7099cc2699059f972fa056c0
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 21 Nov 2018 15:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment