Change in coreboot[master]: mb/google/guybrush: Configure debounce duration for Pen Detect GPIO - coreboot-gerrit

22 Mar 2021


      Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, Karthik Ramasubramanian.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51681 )
Change subject: mb/google/guybrush: Configure debounce duration for Pen Detect GPIO
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51681/comment/463781a3_83c9babf 
PS1, Line 13: Guyrbush 
nit: spelling
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51681/comment/a10d7300_aaaa896c 
PS1, Line 19: S0i3
Also add a define for S0i3_S3 and use that?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I332707322925fa3fd75c47dd76335c818387296b
Gerrit-Change-Number: 51681
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Mathew King mathewk@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 18:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment