Change in ...coreboot[master]: mb/intel/saddlebrook: Fix 2nd DIMM slot

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31630

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

mb/intel/saddlebrook: Fix 2nd DIMM slot

Assumed broken during review and rebase. The
SPD at address 0x52 will appear at index 1.

Change-Id: I213853d2b981294554d8d1b254da476905a41c13
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/intel/saddlebrook/romstage.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31630/1

diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c
index 5b4732a..d19629c 100644
--- a/src/mainboard/intel/saddlebrook/romstage.c
+++ b/src/mainboard/intel/saddlebrook/romstage.c
@@ -56,7 +56,7 @@
    printk(BIOS_SPEW, "spd block length: 0x%08x\n", blk.len);

memory_params->MemorySpdPtr00 = (UINT32) blk.spd_array[0];
-	memory_params->MemorySpdPtr10 = (UINT32) blk.spd_array[2];
+	memory_params->MemorySpdPtr10 = (UINT32) blk.spd_array[1];
    printk(BIOS_SPEW, "0x%08x: SpdDataBuffer_0_0\n",
    	memory_params->MemorySpdPtr00);
    printk(BIOS_SPEW, "0x%08x: SpdDataBuffer_1_0\n",

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

Patch Set 1:

See last comment in CL:21436

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

Patch Set 1:
> Patch Set 1:
>
> See last comment in CL:21436

Sorry, CB:21436

[PraveenX Hodagatta Pranesh (Code Review)]

PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

Patch Set 1: Code-Review+1
> Patch Set 1:
> > Patch Set 1:
> >
> > See last comment in CL:21436
>
> Sorry, CB:21436

Tested on saddle Brook RVP and able to boot on 2nd DIMM slot. Thanks for the Fixing :-)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/31630/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31630/1//COMMIT_MSG@11 
PS1, Line 11: 
Maybe add more details (your comment from the review):
> I believe this should have changed to spd_array[1] after blk.add_map was
> modified after patchset 7. I would asssume 2nd DIMM slot to currently not
> work.

https://review.coreboot.org/#/c/31630/1//COMMIT_MSG@12 
PS1, Line 12: Change-Id: I213853d2b981294554d8d1b254da476905a41c13
Fixes: commit 4dee7b52 (mainboard/intel/saddlebrook: add support for Saddle Brook)

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31630 )

Change subject: mb/intel/saddlebrook: Fix 2nd DIMM slot
......................................................................

mb/intel/saddlebrook: Fix 2nd DIMM slot

Assumed broken during review and rebase. The
SPD at address 0x52 will appear at index 1.

Change-Id: I213853d2b981294554d8d1b254da476905a41c13
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/31630
Tested-by: build bot (Jenkins) 
Reviewed-by: PraveenX Hodagatta Pranesh 
Reviewed-by: Angel Pons 
---
M src/mainboard/intel/saddlebrook/romstage.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  PraveenX Hodagatta Pranesh: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c
index 5b4732a..d19629c 100644
--- a/src/mainboard/intel/saddlebrook/romstage.c
+++ b/src/mainboard/intel/saddlebrook/romstage.c
@@ -56,7 +56,7 @@
    printk(BIOS_SPEW, "spd block length: 0x%08x\n", blk.len);

memory_params->MemorySpdPtr00 = (UINT32) blk.spd_array[0];
-	memory_params->MemorySpdPtr10 = (UINT32) blk.spd_array[2];
+	memory_params->MemorySpdPtr10 = (UINT32) blk.spd_array[1];
    printk(BIOS_SPEW, "0x%08x: SpdDataBuffer_0_0\n",
    	memory_params->MemorySpdPtr00);
    printk(BIOS_SPEW, "0x%08x: SpdDataBuffer_1_0\n",