Change in ...coreboot[master]: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33429

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

{mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length

Change-Id: I671daab8a654b690cec4c872e800b196f7975b9d
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/amd/torpedo/fadt.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/nvidia/ck804/fadt.c
6 files changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/33429/1

diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
index 845af71..9f6d48c 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
@@ -35,7 +35,7 @@
    /* Prepare the header */
    memset((void *)fadt,0,sizeof(acpi_fadt_t));
    memcpy(header->signature,"FACP",4);
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id,OEM_ID,6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
diff --git a/src/mainboard/amd/torpedo/fadt.c b/src/mainboard/amd/torpedo/fadt.c
index 9e33c07..3400fcb 100644
--- a/src/mainboard/amd/torpedo/fadt.c
+++ b/src/mainboard/amd/torpedo/fadt.c
@@ -49,7 +49,7 @@
    /* Prepare the header */
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = 1;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
diff --git a/src/southbridge/amd/sb700/fadt.c b/src/southbridge/amd/sb700/fadt.c
index 4a5746c..c81e644 100644
--- a/src/southbridge/amd/sb700/fadt.c
+++ b/src/southbridge/amd/sb700/fadt.c
@@ -36,7 +36,7 @@
    /* Prepare the header */
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
diff --git a/src/southbridge/amd/sb800/fadt.c b/src/southbridge/amd/sb800/fadt.c
index 71bdf23..acda6db 100644
--- a/src/southbridge/amd/sb800/fadt.c
+++ b/src/southbridge/amd/sb800/fadt.c
@@ -36,7 +36,7 @@
    /* Prepare the header */
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = get_acpi_table_revision(FADT);
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 9515c01..7669761 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -38,7 +38,7 @@

memset((void *) fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = 1;
    memcpy(header->oem_id, OEM_ID, 6);
    memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c
index f6ad479..ee0adf4 100644
--- a/src/southbridge/nvidia/ck804/fadt.c
+++ b/src/southbridge/nvidia/ck804/fadt.c
@@ -34,7 +34,7 @@
    memset((void *)fadt, 0, sizeof(acpi_fadt_t));
    memcpy(header->signature, "FACP", 4);
 #ifdef LONG_FADT
-	header->length = 244;
+	header->length = sizeof(acpi_fadt_t);
    header->revision = get_acpi_table_revision(FADT);
 #else
    header->length = 0x74;

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33429

to look at the new patch set (#2).

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

{mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length

Change-Id: I671daab8a654b690cec4c872e800b196f7975b9d
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/amd/torpedo/fadt.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
5 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/33429/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33429 )

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

I don't think it's the right size.

https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_... 
File src/mainboard/amd/serengeti_cheetah_fam10/fadt.c:

https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_... 
PS2, Line 38: 
What would 'typeof header' say?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33429 )

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_... 
File src/mainboard/amd/serengeti_cheetah_fam10/fadt.c:

https://review.coreboot.org/#/c/33429/2/src/mainboard/amd/serengeti_cheetah_... 
PS2, Line 38:
> What would 'typeof header' say?

Or does this 'header->length' refer to the whole table's length?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33429 )

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

Patch Set 2: Code-Review+1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33429 )

Change subject: {mb,sb}/fadt.c: Use sizeof(acpi_fadt_t) for header length
......................................................................

Abandoned

see 33437