Change in coreboot[master]: amdfwtool: Set the region_type as 0 for entry "BIOS level 2" - coreboot-gerrit

26 May 2021


      Attention is currently required from: Bao Zheng, Raul Rangel, Zheng Bao.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54871 )
Change subject: amdfwtool: Set the region_type as 0 for entry "BIOS level 2"
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/54871/comment/3b3f351a_dafc0a9c 
PS2, Line 1047: region_type
...
So this changes the region type from 0xFF to 0?
Yes, only for the type 0x70 entry, which is the pointer to the 2nd level of the table.  I don't see any description for valid values for this field however I'd missed it when writing the code.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b914f9f02beecce707aba86248826cd9208e6c0
Gerrit-Change-Number: 54871
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Wed, 26 May 2021 21:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment