Change in coreboot[master]: mainboard/google/hatch: Add Palkia support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

23 Feb 2020 23 Feb '20

6:45 p.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:none BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Helios target.

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 783ec73..3add7ab 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -98,6 +98,7 @@ default "Kindred" if BOARD_GOOGLE_KINDRED default "Kohaku" if BOARD_GOOGLE_KOHAKU default "Mushu" if BOARD_GOOGLE_MUSHU + default "Palkia" if BOARD_GOOGLE_PALKIA default "Puff" if BOARD_GOOGLE_PUFF default "Stryke" if BOARD_GOOGLE_STRYKE

@@ -121,6 +122,7 @@ default "kindred" if BOARD_GOOGLE_KINDRED default "kohaku" if BOARD_GOOGLE_KOHAKU default "mushu" if BOARD_GOOGLE_MUSHU + default "palkia" if BOARD_GOOGLE_PALKIA default "puff" if BOARD_GOOGLE_PUFF default "stryke" if BOARD_GOOGLE_STRYKE

diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e216135..c2dd7ca 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -60,3 +60,10 @@ bool "-> Stryke" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 + +config BOARD_GOOGLE_PALKIA + bool "-> Palkia" + select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_ROMSIZE_KB_16384 + select CHROMEOS_DSM_CALIB + select DRIVERS_I2C_RT1011

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Kane Chen (Code Review)

23 Feb 23 Feb

6:49 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1: Code-Review+1

Zhuohao Lee (Code Review)

6:55 p.m.

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1: Code-Review+1

Paul Menzel (Code Review)

24 Feb 24 Feb

3:25 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG@7 PS1, Line 7: mainboard mb

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 24 Feb 2020 11:25:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ken Lu (Code Review)

4:04 a.m.

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG@7 PS1, Line 7: mainboard

...

mb

mainboard is folder name under coreboot . Should we change it to mb ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 24 Feb 2020 12:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

6:44 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1:

(1 comment)

Can you look into why the build is failing and this is getting marked Verified-1?

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG@14 PS1, Line 14: Helios Palkia

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 24 Feb 2020 14:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:56 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1:

(1 comment)

The error can be found in https://qa.coreboot.org/job/coreboot-gerrit/117388/testReport/junit/(root)/b...

SCONFIG mainboard/google/hatch/variants/baseboard/devicetree.cb line 159: : syntax error

I'm not sure how reliable the line number is in an overridetree, but there's some syntax error _somewhere_.

Please merge this with its parent commit, so that we don't have a commit that adds inactive code to the tree. Otherwise we see errors here that are really the result of something in the other commit (like in this example).

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39096/1//COMMIT_MSG@7 PS1, Line 7: mainboard

...

mainboard is folder name under coreboot . […]

Originally, we spelled out paths in long form. For "mainboard" specifically, some contributors use the "mb" short hand. You _can_ use it, but you don't have to.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 24 Feb 2020 14:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ken Lu ken_lu@pegatron.corp-partner.google.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Duncan Laurie (Code Review)

7:04 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 1:

...

Patch Set 1:

(1 comment)

The error can be found in https://qa.coreboot.org/job/coreboot-gerrit/117388/testReport/junit/(root)/b...
SCONFIG    mainboard/google/hatch/variants/baseboard/devicetree.cb
line 159: : syntax error

I'm not sure how reliable the line number is in an overridetree, but there's some syntax error _somewhere_.

Please merge this with its parent commit, so that we don't have a commit that adds inactive code to the tree. Otherwise we see errors here that are really the result of something in the other commit (like in this example).

I noted it in the previous commit, looks like an 'end' statement is missing.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 24 Feb 2020 15:04:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

6:19 p.m.

Hello Zhuohao Lee, Zhuohao Lee, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39096

to look at the new patch set (#2).

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:none BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Helios target.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

6:22 p.m.

Hello Zhuohao Lee, Zhuohao Lee, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39096

to look at the new patch set (#3).

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:none BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Helios target.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

25 Feb 25 Feb

8:36 p.m.

Hello Zhuohao Lee, Zhuohao Lee, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39096

to look at the new patch set (#4).

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:none BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Palkia target.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

11:02 p.m.

Hello Zhuohao Lee, Zhuohao Lee, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39096

to look at the new patch set (#5).

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:150254194 BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Palkia target.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

10 Mar 10 Mar

7:51 p.m.

Hello Shelley Chen, build bot (Jenkins), Tim Wawrzynczak, Paul Fagerburg, Zhuohao Lee, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39096

to look at the new patch set (#6).

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

mainboard/google/hatch: Add Palkia support

Add Palkia as a variant of Hatch.

BUG=b:150254194 BRANCH=None TEST=util/abuild/abuild -p none -t google/hatch -x -a attempts to build a Palkia target.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/39096/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

7:53 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 6: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 02:53:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11 Mar 11 Mar

7:16 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 6:

Shouldn't this be part of CB:38860 ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 14:16:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

7:20 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 6: Code-Review-1

...

Patch Set 6:

Shouldn't this be part of CB:38860 ?

+1. These changes are in CB:38860 and so this CL is unnecessary and should be abandoned.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 14:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kane Chen (Code Review)

15 Mar 15 Mar

5:57 p.m.

Kane Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Abandoned

These changes add to CB:38860.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Kane Chen (Code Review)

5:57 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39096 )

Change subject: mainboard/google/hatch: Add Palkia support ......................................................................

Patch Set 6:

...

Patch Set 6: Code-Review-1

...
Patch Set 6:

Shouldn't this be part of CB:38860 ?

+1. These changes are in CB:38860 and so this CL is unnecessary and should be abandoned.

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifeb1e2808f3779a1a1c4da9b71b535b02fb4e1e0 Gerrit-Change-Number: 39096 Gerrit-PatchSet: 6 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Duncan Laurie dlaurie@chromium.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Mar 2020 00:57:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1828

days inactive

1849

days old

coreboot-gerrit@coreboot.org

17 comments

8 participants

tags (0)

participants (8)

Angel Pons (Code Review)
Duncan Laurie (Code Review)
Kane Chen (Code Review)
Ken Lu (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)
Zhuohao Lee (Code Review)