Attention is currently required from: Amanda Hwang, Ian Feng, Pranava Y N.
Dtrain Hsu has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/85037?usp=email )
Change subject: mb/google/fatcat/var/francka: Update gpio settings
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/francka/gpio.c:
https://review.coreboot.org/c/coreboot/+/85037/comment/7eaf7547_1778fdd8?usp... :
PS6, Line 219: used_R
Should it delete _R?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85037?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I759df174a47a08319c1ada649d8bfb6f64b5aecd
Gerrit-Change-Number: 85037
Gerrit-PatchSet: 6
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 11 Nov 2024 09:05:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No