Change in coreboot[master]: mb/google/brya/var/gimble: Group fw_config pad tables - coreboot-gerrit

7 Feb 2022


      Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61151 )
Change subject: mb/google/brya/var/gimble: Group fw_config pad tables
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: 
LGTM with minor modification.
File src/mainboard/google/brya/variants/gimble/fw_config.c:
https://review.coreboot.org/c/coreboot/+/61151/comment/e5c394fe_371a7264 
PS1, Line 70: 0
can we use enum instead `0` or `1`
Isn't it more like `0` for disable and `1` for enable?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9888950db254c6ccd9040ea7a61c049fd4a519c7
Gerrit-Change-Number: 61151
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment