Change in ...coreboot[master]: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option

[Joel Kitching (Code Review)]

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31926

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option

This option is duplicated in depthcharge:
https://crrev.com/c/1524811

BUG=b:124141368, b:124192753, b:128737909
TEST=Build and deploy to eve
TEST=util/lint/checkpatch.pl -g origin/master..HEAD
TEST=util/abuild/abuild -B -e -y -c 50 -p none -x
TEST=make clean && make test-abuild
CQ-DEPEND=CL:1524811
BRANCH=none

Change-Id: Id8c207ec4ad5a476e24eee1ceb9e40f24d55e725
Signed-off-by: Joel Kitching 
---
M src/security/vboot/Kconfig
M src/security/vboot/vboot_handoff.c
2 files changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31926/1

diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index 67853ab..ef5455f 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -176,15 +176,6 @@
    bool
    default n

-config VBOOT_EC_SOFTWARE_SYNC
-	bool "Enable EC software sync"
-	default y if EC_GOOGLE_CHROMEEC
-	default n
-	help
-	  EC software sync is a mechanism where the AP helps the EC verify its
-	  firmware similar to how vboot verifies the main system firmware. This
-	  option selects whether vboot should support EC software sync.
-
 config VBOOT_PHYSICAL_DEV_SWITCH
    bool
    default n
diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c
index 5ac627c..c916b6d 100644
--- a/src/security/vboot/vboot_handoff.c
+++ b/src/security/vboot/vboot_handoff.c
@@ -81,8 +81,6 @@
    /* TODO: Set these in depthcharge */
    if (!CONFIG(VBOOT_PHYSICAL_DEV_SWITCH))
    	vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH;
-	if (CONFIG(VBOOT_EC_SOFTWARE_SYNC))
-		vb_sd->flags |= VBSD_EC_SOFTWARE_SYNC;
    if (!CONFIG(VBOOT_PHYSICAL_REC_SWITCH))
    	vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL;
    if (CONFIG(VBOOT_OPROM_MATTERS)) {

[Joel Kitching (Code Review)]

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31926

to look at the new patch set (#2).

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option

This option is duplicated in depthcharge:
https://crrev.com/c/1524811

BUG=b:124141368, b:124192753, b:128737909
TEST=Build and deploy to eve
TEST=util/lint/checkpatch.pl -g origin/master..HEAD
TEST=util/abuild/abuild -B -e -y -c 50 -p none -x
TEST=make clean && make test-abuild
CQ-DEPEND=CL:1524811
BRANCH=none

Change-Id: Id8c207ec4ad5a476e24eee1ceb9e40f24d55e725
Signed-off-by: Joel Kitching 
---
M src/security/vboot/Kconfig
M src/security/vboot/vboot_handoff.c
2 files changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31926/2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 3:

VBOOT_EC_SOFTWARE_SYNC is also set here: https://review.coreboot.org/cgit/coreboot.git/tree/src/ec/google/wilco/Kconf...

[Joel Kitching (Code Review)]

Hello Aaron Durbin, Julius Werner, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31926

to look at the new patch set (#4).

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option

This option is duplicated in depthcharge:
https://crrev.com/c/1524811

BUG=b:124141368, b:124192753, b:128737909
TEST=Build and deploy to eve
TEST=util/lint/checkpatch.pl -g origin/master..HEAD
TEST=util/abuild/abuild -B -e -y -c 50 -p none -x
TEST=make clean && make test-abuild
CQ-DEPEND=CL:1524811
BRANCH=none

Change-Id: Id8c207ec4ad5a476e24eee1ceb9e40f24d55e725
Signed-off-by: Joel Kitching 
---
M src/ec/google/wilco/Kconfig
M src/security/vboot/Kconfig
M src/security/vboot/vboot_handoff.c
3 files changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/31926/4

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 4: Code-Review+1
> Patch Set 3:
>
> VBOOT_EC_SOFTWARE_SYNC is also set here: https://review.coreboot.org/cgit/coreboot.git/tree/src/ec/google/wilco/Kconf...

Thanks.  I've updated the depthcharge CL to include sarien and arcada.
https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 4: Code-Review+2

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 5:

CQ-DEPEND is merged.  Could we submit this please?

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 5:

Gerrit won't let me submit it, I think you need to rebase or something?

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 6:

Rebased... does that help?

[Simon Glass (Code Review)]

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

Patch Set 6: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31926 )

Change subject: vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option
......................................................................

vboot: remove VBOOT_EC_SOFTWARE_SYNC Kconfig option

This option is duplicated in depthcharge:
https://crrev.com/c/1524811

BUG=b:124141368, b:124192753, b:128737909
TEST=Build and deploy to eve
TEST=util/lint/checkpatch.pl -g origin/master..HEAD
TEST=util/abuild/abuild -B -e -y -c 50 -p none -x
TEST=make clean && make test-abuild
CQ-DEPEND=CL:1524811
BRANCH=none

Change-Id: Id8c207ec4ad5a476e24eee1ceb9e40f24d55e725
Signed-off-by: Joel Kitching 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31926
Reviewed-by: Simon Glass 
Reviewed-by: Furquan Shaikh 
Tested-by: build bot (Jenkins) 
---
M src/security/vboot/Kconfig
M src/security/vboot/vboot_handoff.c
2 files changed, 0 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Simon Glass: Looks good to me, approved
  Joel Kitching: Looks good to me, but someone else must approve

diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index 004113b..42e7b19 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -191,15 +191,6 @@
    bool
    default n

-config VBOOT_EC_SOFTWARE_SYNC
-	bool "Enable EC software sync"
-	default y if EC_GOOGLE_CHROMEEC
-	default n
-	help
-	  EC software sync is a mechanism where the AP helps the EC verify its
-	  firmware similar to how vboot verifies the main system firmware. This
-	  option selects whether vboot should support EC software sync.
-
 config VBOOT_PHYSICAL_DEV_SWITCH
    bool
    default n
diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c
index f009440..cbfedf5 100644
--- a/src/security/vboot/vboot_handoff.c
+++ b/src/security/vboot/vboot_handoff.c
@@ -81,8 +81,6 @@
    /* TODO: Set these in depthcharge */
    if (!CONFIG(VBOOT_PHYSICAL_DEV_SWITCH))
    	vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH;
-	if (CONFIG(VBOOT_EC_SOFTWARE_SYNC))
-		vb_sd->flags |= VBSD_EC_SOFTWARE_SYNC;
    if (!CONFIG(VBOOT_PHYSICAL_REC_SWITCH))
    	vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL;
    if (CONFIG(VBOOT_OPROM_MATTERS)) {