Attention is currently required from: Patrick Rudolph, Christian Walter, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58368 )
Change subject: mb/prodrive/hermes: Map PCIe clocks to root ports
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/58368/comment/f2a0f4f0_e113bdd0
PS2, Line 30: register "PcieClkSrcUsage[0]" = "20" # PCIe Slot1
might be good to have defines or depending on what this actually does an enum in the soc code for th […]
I'll address this in a follow-up. I'd like to properly abstract the clock source and clock request settings with a struct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0515877a36d42fb8858a0f0b3c0af1199a18d9af
Gerrit-Change-Number: 58368
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Oct 2021 14:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment