Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55143 )
Change subject: soc/intel/alderlake: Set SaIpuEnable UPD from device state
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55143/comment/779c92ab_02afd7e5
PS1, Line 218: dev = pcidev_path_on_root(SA_DEVFN_IPU);
Isn't dev already assigned the way you need it here in line 207? Why do you need to repeat it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53752f92c4b49093218cc34848727a72b63e84eb
Gerrit-Change-Number: 55143
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Jun 2021 05:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment