Attention is currently required from: Shelley Chen, Ravi Kumar Bokka. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63085 )
Change subject: Performance improvement by removing delays in cpucp init ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/google/herobrine/romstage.c:
https://review.coreboot.org/c/coreboot/+/63085/comment/8e52c5d3_a540de31 PS3, Line 19: void cpucp_prepare(void) You should keep this function in SoC code and just link that file into romstage, then call it from here.
https://review.coreboot.org/c/coreboot/+/63085/comment/76000d5f_1834543e PS3, Line 33: cpucp_prepare(); Does this need to run after QcLib? If so, please explain why in a comment. If not, probably better to move it before QcLib because that's the biggest time sink here in romstage.
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/63085/comment/b5b453e0_08a82c1f PS3, Line 12: Should be no more than one blank line here.
https://review.coreboot.org/c/coreboot/+/63085/comment/77756b5f_6a2f1e05 PS3, Line 15: { You still need to keep the wait_ms(...) here because there's no guarantee that enough time passed between romstage and now.
-
Julius Werner (Code Review)