Attention is currently required from: Raul Rangel, Marshall Dawson, Julian Schroeder.
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52909 )
Change subject: src/vendorcode/amd/fsp/cezanne/FspmUpd.h: match amd-fsp
......................................................................
Patch Set 1:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52909/comment/92e6c2b2_35bd4911
PS1, Line 81: /** Offset 0x0449**/ uint8_t emmc0_sdr50_driver_strength;
You deleted all of these fields on the FSP side of the change. Is this intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib40c30e18878db5604ed1104e1e876986212e67d
Gerrit-Change-Number: 52909
Gerrit-PatchSet: 1
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Comment-Date: Wed, 12 May 2021 17:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment