Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37882 )
Change subject: src/drivers/i2c: add i2c driver for Realtek 1308
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/chip...
File src/drivers/i2c/rt1308/chip.h:
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/chip...
PS2, Line 26: uint32_t
if intention is only 0 or 1 then i believe Paul is right about the usage of variable.
but definition and variable name doesn't look same. uid could be any thing not only 0 or 1
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt13...
File src/drivers/i2c/rt1308/rt1308.c:
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt13...
PS2, Line 23: #include <stdint.h>
redundant i believe already part of header
https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt13...
PS2, Line 25: #include "chip.h"
can u use this one rather being direct
#include <soc/soc_chip.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44fc8199f2153e18537023dfd92e0ce6a3ecb9c
Gerrit-Change-Number: 37882
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 15 Jan 2020 14:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment