Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790
......................................................................
Patch Set 59:
(3 comments)
https://review.coreboot.org/c/coreboot/+/21774/59//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/21774/59//COMMIT_MSG@14
PS59, Line 14: - MT: 4 RAM slots, PEG, PCIe x1, PCI, PCIe x16
*three* is before the list, and the list has four items. Make it clear, that the first two boards are identical?
https://review.coreboot.org/c/coreboot/+/21774/59//COMMIT_MSG@42
PS59, Line 42: - VBT is missing
Are VBT’s needed for desktop systems?
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple...
File src/mainboard/dell/optiplex_790/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/21774/59/src/mainboard/dell/optiple...
PS59, Line 18: */
This is not added in the latest autoport version.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 59
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 15 Jan 2020 14:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment