Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38013 )
Change subject: soc/intel/common/systemagent: add Kconfig guard
......................................................................
Patch Set 2:
I don't mind such guards. But the reason seems spurious as it seems
to work fine everywhere.
There are some pitfalls, maybe something is wrong with the way your
platform is hooked up? If you look at `soc/intel/Kconfig` all plat-
forms precede the `source` for `common/Kconfig`, so they can set a
different default (and the first default takes precedence in Kconfig).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38013
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7b9e18f6169d91732a1db7e8eabf137b66072dd
Gerrit-Change-Number: 38013
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
dhendrix.sync@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jan 2020 14:28:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment