Attention is currently required from: Martin Roth, Marshall Dawson, Julius Werner, Kyösti Mälkki, Yu-Ping Wu, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 )
Change subject: Makefile.inc: Add the x86 bootblock as a regular cbfs file ......................................................................
Patch Set 7:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/f9f8ade9_a71c2d5e PS3, Line 840: This top aligns files of type bootblock, assuming that only x86 uses those
You're right, in the current state, the bootblock area is no longer needed on AMD Ryzen systems because we use the compressed version inside the AMD FW area.
I believe that we could actually still use it if we wanted to just by pointing the "BIOS" area in EFS to our uncompressed bootblock region.
As an aside, I'd actually really like to get away from the whole amdfwtool being used to create a bin binary. Except for the additional CBFS headers, I don't see any advantage to amdfwtool's method over just adding all of the various binaries separately in CBFS, then telling a new EFS generation tool where they are. I think that would allow for a lot more flexibility.
Do you mean that you would prefer it to just execute the bootblock XIP at the end top of 4G? Currently we don't use the fact that the bootblock is in memory all that well but it seems to allow for some neat opportunities, that I'd like to explore like having only one stage. Are we though talking about the same thing?
-
Arthur Heymans (Code Review)