Hello Furquan Shaikh, Subrata Banik, Michael Niewöhner,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45633
to review the following change.
Change subject: soc/intel/skl: Fix error code of send_global_reset() ......................................................................
soc/intel/skl: Fix error code of send_global_reset()
With commit f2eb687d19 (soc/intel/{cnl,icl,skl,tgl,common}: Make changes to send_heci_reset_req_message()) the return value was changed on a single path. Update the other paths too, even though it's the discouraged 0-is-failure.
Change-Id: I179a6a4b1e13565dd58c908eb2a9725052a4de9d Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/skylake/me.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/45633/1
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index c37f692..92a7daf 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -340,7 +340,7 @@
int send_global_reset(void) { - int status = -1; + int status = 0; union me_hfsts1 hfs1;
if (!is_cse_enabled())
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45633 )
Change subject: soc/intel/skl: Fix error code of send_global_reset() ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45633 )
Change subject: soc/intel/skl: Fix error code of send_global_reset() ......................................................................
soc/intel/skl: Fix error code of send_global_reset()
With commit f2eb687d19 (soc/intel/{cnl,icl,skl,tgl,common}: Make changes to send_heci_reset_req_message()) the return value was changed on a single path. Update the other paths too, even though it's the discouraged 0-is-failure.
Change-Id: I179a6a4b1e13565dd58c908eb2a9725052a4de9d Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/45633 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/skylake/me.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c index c37f692..92a7daf 100644 --- a/src/soc/intel/skylake/me.c +++ b/src/soc/intel/skylake/me.c @@ -340,7 +340,7 @@
int send_global_reset(void) { - int status = -1; + int status = 0; union me_hfsts1 hfs1;
if (!is_cse_enabled())
-
Furquan Shaikh (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)