Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Jianjun Wang, Julius Werner, Ron Minnich, Shelley Chen, Yu-Ping Wu.
Nico Huber has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email )
Change subject: arch/io.h: Add port I/O functions to other architectures
......................................................................
Patch Set 5:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/80372/comment/aaccc5ad_5768f2f7?usp... :
PS5, Line 532: CPU communicate with peripheral devices over PCI I/O space.
Hmm... […]
`resource_t` is a mere integer. `struct resource` is used to describe resources,
so far. But not directly to access them in an abstract way, i.e. no function
pointers that could point to a PCI controller's specific implementation. What
all the drivers do, AFAICT, is to simply feed `res->base + something` to the
global functions. So the problem seems the same, no matter where the address
comes from.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80372?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9
Gerrit-Change-Number: 80372
Gerrit-PatchSet: 5
Gerrit-Owner: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 30 May 2024 16:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Alper Nebi Yasak
alpernebiyasak@gmail.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com