[L] Change in coreboot[main]: haswell NRI: Initialise MPLL - coreboot-gerrit

11 Apr 2024


      Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64184?usp=email )
Change subject: haswell NRI: Initialise MPLL
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File src/northbridge/intel/haswell/native_raminit/init_mpll.c:
https://review.coreboot.org/c/coreboot/+/64184/comment/5beaabbc_84f1d434 :
PS3, Line 107: 		ctrl->tCK++;
...
Seems spurious, it is already done on the caller side
What was I thinking when I wrote that?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I978c352de68f6d8cecc76f4ae3c12daaf4be9ed6
Gerrit-Change-Number: 64184
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 11 Apr 2024 16:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment