Patch set updated for coreboot: d9a0a57 X201: Move early nehalem S3 magic to right place.

[Vladimir Serbinenko]

Vladimir Serbinenko ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4632

-gerrit

commit d9a0a57385508903ae0b89f9f1110c71ad0fe112
Author: Vladimir Serbinenko 
Date:   Thu Jan 9 11:13:18 2014 +0100

X201: Move early nehalem S3 magic to right place.

This MCH magic needs to be done before GPIO.

Change-Id: I319e57af52ff01083bfbffbcd883ac5f453320a1
    Signed-off-by: Vladimir Serbinenko 
---
 src/mainboard/lenovo/x201/romstage.c       | 12 +++---------
 src/northbridge/intel/nehalem/early_init.c |  6 ++++++
 src/northbridge/intel/nehalem/raminit.c    |  7 -------
 3 files changed, 9 insertions(+), 16 deletions(-)

diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c
index 8022d7b..fbf240e 100644
--- a/src/mainboard/lenovo/x201/romstage.c
+++ b/src/mainboard/lenovo/x201/romstage.c
@@ -239,25 +239,19 @@ void main(unsigned long bist)
    if (bist == 0)
    	enable_lapic();

-	/* Force PCIRST# */
-	pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, SBR);
-	pci_write_config16(PCI_DEV(0, 0, 0), BCTRL, SBR);
-	udelay(200 * 1000);
-	pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, 0);
-	pci_write_config16(PCI_DEV(0, 0, 0), BCTRL, 0);
+	nehalem_early_initialization(NEHALEM_MOBILE);
+
+	pch_enable_lpc();

/* Enable USB Power. We need to do it early for usbdebug to work. */
    ec_set_bit(0x3b, 4);

-	pch_enable_lpc();
-
    /* Enable GPIOs */
    pci_write_config32(PCH_LPC_DEV, GPIO_BASE, DEFAULT_GPIOBASE | 1);
    pci_write_config8(PCH_LPC_DEV, GPIO_CNTL, 0x10);

setup_pch_gpios(&x201_gpio_map);

-	nehalem_early_initialization(NEHALEM_MOBILE);

/* This should probably go away. Until now it is required
     * and mainboard specific
diff --git a/src/northbridge/intel/nehalem/early_init.c b/src/northbridge/intel/nehalem/early_init.c
index 81bac87..ee8c17a 100644
--- a/src/northbridge/intel/nehalem/early_init.c
+++ b/src/northbridge/intel/nehalem/early_init.c
@@ -166,4 +166,10 @@ void nehalem_early_initialization(int chipset_type)
    pci_write_config32(PCI_DEV(0, 0x16, 0), 0x10, DEFAULT_HECIBAR);
    pci_write_config32(PCI_DEV(0, 0x16, 0), PCI_COMMAND,
    		   PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY);
+
+	/* Magic for S3 resume. Must be done early.  */
+	if (((inl(DEFAULT_PMBASE + PM1_CNT) >> 10) & 7) == SLP_TYP_S3) {
+		MCHBAR32 (0x1e8) = (MCHBAR32(0x1e8) & ~1) | 6;
+		MCHBAR32 (0x1e8) = (MCHBAR32(0x1e8) & ~3) | 4;
+	}
 }
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c
index 0ecd413..f48b277 100644
--- a/src/northbridge/intel/nehalem/raminit.c
+++ b/src/northbridge/intel/nehalem/raminit.c
@@ -3815,13 +3815,6 @@ void raminit(const int s3resume)
    unsigned channel, slot, lane, rank;
    int i;
    struct raminfo info;
-	if (s3resume) {
-		read_mchbar32(0x1e8);
-		write_mchbar32(0x1e8, 0x6);
-		read_mchbar32(0x1e8);
-		write_mchbar32(0x1e8, 0x4);
-	}
-
    u8 x2ca8;

gav(x2ca8 = read_mchbar8(0x2ca8));