Change in coreboot[master]: drivers/intel/usb4/retimer: Update code to assign correct port number - coreboot-gerrit

1 Jul 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55945 )
Change subject: drivers/intel/usb4/retimer: Update code to assign correct port number
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/usb4/retimer/chip.h:
https://review.coreboot.org/c/coreboot/+/55945/comment/eaad25ac_d7ae56a9 
PS1, Line 20: uint8_t controller;
...
It looks like this is only used to calculate the USB port number. […]
Ohk..this is good. Thank you Tim..wasn't aware we can do that. :)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55945
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11637ae39046e0afdacd33bc34e8a59e6f2bfb1
Gerrit-Change-Number: 55945
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Deepti Deshatty deepti.deshatty@intel.com
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 06:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment