Attention is currently required from: Julius Werner, Maximilian Brune, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80776?usp=email )
Change subject: lib: Declare heap in assembly
......................................................................
Patch Set 3:
(1 comment)
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/80776/comment/3880b474_42bde7ed :
PS3, Line 141: }
I think a simpler solution is to just add a `: to_load` here. (We already have that for the `.text` section as well, although I'm not sure why. It is implicit everywhere else too, so maybe we should just make it explicit everywhere to reduce ambiguity.)
That works indeed. It's a bit confusing to have (NOLOAD) and to_load for the same section?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67cb5ce886fda313e0720b0bc7c6e66e4aae45fa
Gerrit-Change-Number: 80776
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 29 Feb 2024 13:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment