Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/29006
Change subject: ec/google/chromeec: Get rid of __SMM__ guard for chromeec functions ......................................................................
ec/google/chromeec: Get rid of __SMM__ guard for chromeec functions
There doesn't seem to be a reason why we would want to protect certain chromeec functions with __SMM__ guard. So, this change gets rid of it. If the functions remain unused, then they would be removed during linking.
Change-Id: I8196406074b01fe8ea15173c55d45bb86384be1b Signed-off-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/ec.c 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/29006/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 90fcc3d..75d9da1 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -636,7 +636,6 @@ return 0; }
-#ifndef __SMM__ int google_chromeec_get_board_version(uint32_t *version) { struct chromeec_command cmd; @@ -713,8 +712,6 @@ return cec_cmd.cmd_code; }
-#endif /* ! __SMM__ */ - #ifndef __PRE_RAM__
int google_chromeec_i2c_xfer(uint8_t chip, uint8_t addr, int alen, @@ -920,8 +917,6 @@ return google_chromeec_command(&cmd); }
-#ifndef __SMM__ - static int google_chromeec_hello(void) { struct chromeec_command cec_cmd; @@ -1106,7 +1101,6 @@ { return (ec_image_type == EC_IMAGE_RO); } -#endif /* ! __SMM__ */
#endif /* ! __PRE_RAM__ */