Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Nico Huber, Subrata Banik, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: Add MTCL function to ACPI SSDT tables
......................................................................
Patch Set 14:
(2 comments)
File src/drivers/wifi/generic/mtcl.c:
https://review.coreboot.org/c/coreboot/+/80170/comment/199f722c_b2a4114b :
PS14, Line 9: WIFI_MTCL_CBFS_DEFAULT_FILENAME "wifi_mtcl.hex"
This is the filename inside CBFS, as hardcoded in the Makefile.mk, isn't it?
The Kconfig is for the file path on the build host.
i got confused with CONFIG_WIFI_MTCL_CBFS_FILEPATH which is a host file path
https://review.coreboot.org/c/coreboot/+/80170/comment/f4a76bb7_bb97214c :
PS14, Line 10: #define MAX_VERSION 2
: #define MAX_SUPPORT_STATE 2
: #define COUNTRY_LIST_SIZE 6
: #define NAME_SIZE 4
: #define MTCL_NAME "MTCL"
The API user doesn't need to know this, so I'd say no.
for sure, for a moment i thought the header file is local to this directory
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350
Gerrit-Change-Number: 80170
Gerrit-PatchSet: 14
Gerrit-Owner: David Ruth
druth@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: David Ruth
druth@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Thu, 01 Feb 2024 13:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment