Change in coreboot[master]: src/lib/cbfs: Remove unused macro

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

27 May 2020 27 May '20

3:36 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

src/lib/cbfs: Remove unused macro

Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/cbfs.c 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41781/1

diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index a3294de..92a6fed 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -17,11 +17,6 @@

#define ERROR(x...) printk(BIOS_ERR, "CBFS: " x) #define LOG(x...) printk(BIOS_INFO, "CBFS: " x) -#if CONFIG(DEBUG_CBFS) -#define DEBUG(x...) printk(BIOS_SPEW, "CBFS: " x) -#else -#define DEBUG(x...) -#endif

int cbfs_boot_locate(struct cbfsf *fh, const char *name, uint32_t *type) {

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Aaron Durbin (Code Review)

27 May 27 May

4:47 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 27 May 2020 14:47:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

5:28 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 1:

Duplicate of Iae6056c53f668be3326ac6d71e4829d7b493b7e2, but I’ll abandon my change-set.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 15:28:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:19 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 1:

...

Patch Set 1:

Duplicate of Iae6056c53f668be3326ac6d71e4829d7b493b7e2, but I’ll abandon my change-set.

Oops, Sorry Paul

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 16:19:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:20 p.m.

Hello build bot (Jenkins), Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41781

to look at the new patch set (#2).

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

src/lib/cbfs: Remove unused macro

Found-by: gcc using -Wunused-macros warning option Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/cbfs.c 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/41781/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

10:34 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 2:

Would you mind not doing no-op cleanups in this code while it's being rewritten anyway (CB:38422)? It just ends up causing more rebase churn for me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 20:34:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:40 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 2:

...

Patch Set 2:

Would you mind not doing no-op cleanups in this code while it's being rewritten anyway (CB:38422)? It just ends up causing more rebase churn for me.

sure

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 20:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:41 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Abandoned

see https://review.coreboot.org/c/coreboot/+/38422/

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

HAOUAS Elyes (Code Review)

13 Jun 13 Jun

12:04 p.m.

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: restore

Angel Pons (Code Review)

16 Jun 16 Jun

10:20 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41781/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41781/2//COMMIT_MSG@9 PS2, Line 9: Found-by: gcc using -Wunused-macros warning option Are you going to delete chipset register definitions as well just because they are unused?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 20:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9 Oct 9 Oct

3:40 a.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41781 )

Change subject: src/lib/cbfs: Remove unused macro ......................................................................

Abandoned

See 38422

-- To view, visit https://review.coreboot.org/c/coreboot/+/41781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1efdb6355bec6f680e0fb1a4f4e19db93b3739a2 Gerrit-Change-Number: 41781 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1559

days inactive

1694

days old

coreboot-gerrit@coreboot.org

10 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Julius Werner (Code Review)
Paul Menzel (Code Review)