Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54295 )
Change subject: security/intel/txt: Always build logging.c ......................................................................
security/intel/txt: Always build logging.c
Always building makes sure this code gets buildtested. Calling this code already was guarded by "if CONFIG(INTEL_TXT_LOGGING)".
Also build this in all stages as future code will use this in bootblock.
Change-Id: I654adf16b47513e3279335c8a8ad48b9371d438e Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/54295 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/intel/txt/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, but someone else must approve
diff --git a/src/security/intel/txt/Makefile.inc b/src/security/intel/txt/Makefile.inc index d332341..7132ca8 100644 --- a/src/security/intel/txt/Makefile.inc +++ b/src/security/intel/txt/Makefile.inc @@ -1,17 +1,17 @@ ifeq ($(CONFIG_INTEL_TXT),y)
+all-y += logging.c + romstage-y += romstage.c romstage-y += getsec_sclean.S romstage-y += getsec.c
romstage-y += common.c -romstage-$(CONFIG_INTEL_TXT_LOGGING) += logging.c
ramstage-y += common.c ramstage-y += getsec.c ramstage-y += getsec_enteraccs.S ramstage-y += ramstage.c -ramstage-$(CONFIG_INTEL_TXT_LOGGING) += logging.c
cbfs-files-y += $(CONFIG_INTEL_TXT_CBFS_BIOS_ACM) $(CONFIG_INTEL_TXT_CBFS_BIOS_ACM)-file := $(CONFIG_INTEL_TXT_BIOSACM_FILE)