Change in coreboot[master]: arch/x86: Save resume vector to stack in x86_64 mode - coreboot-gerrit

2 Jul 2021


      Attention is currently required from: Arthur Heymans, Iru Cai, Iru Cai (vimacs).
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55947 )
Change subject: arch/x86: Save resume vector to stack in x86_64 mode
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/wakeup.S:
https://review.coreboot.org/c/coreboot/+/55947/comment/96150844_550b423a 
PS2, Line 23: mov
...
Explicitly use movl to make sure only 4 bytes get moved?
In Long Mode the default data size is still 32bits and edi is a 32bit operant, so it likely does the right thing already.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55947
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45f2678071b2511c0af5dce9d9b73ac70dfd7252
Gerrit-Change-Number: 55947
Gerrit-PatchSet: 2
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Iru Cai mytbk920423@gmail.com
Gerrit-Attention: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Comment-Date: Fri, 02 Jul 2021 05:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment