[L] Change in coreboot[main]: superio/ite: Add special fan vectors, unify it8722f with common
Attention is currently required from: Matt DeVillier, Michał Żygowski, MrChromebox, Piotr Król.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Add special fan vectors, unify it8722f with common ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/jecht/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81310/comment/54446bb3_7e171b85 : PS1, Line 84: FAN2.pwm_start
needs to be `FAN2.smart. […]
Done
File src/superio/ite/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/829315a4_473eb62a : PS1, Line 90: void ite_set_3vsbsw(pnp_devfn_t dev, bool enable)
not sure I see the point in changing this, given the disable option isn't used anywhere. […]
I am working on a new port that needs this otherwise it will not fully power down when entering S5. The port is very functional but it still needs documentation and some (m)pcie tests, therefore no changeset yet. I added back the enable function as suggested.
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/6107839c_e2ba1929 : PS1, Line 364: if (CONFIG(SUPERIO_ITE_ENV_CTRL_FAN_VECTOR)) {
needs to be #ifdef'd since the `fan_vector` field doesn't exist if the config isn't set
Done
-
Joel Linn (Code Review)