Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )
Change subject: mb/kontron: Add the Kontron mAL10 COMe module support
......................................................................
Patch Set 41:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39133/24/src/mainboard/kontron/mal1...
File src/mainboard/kontron/mal10/acpi/sbus.asl:
PS24:
rename to smbus.asl […]
Move to CB:44507
https://review.coreboot.org/c/coreboot/+/39133/39/src/mainboard/kontron/mal1...
File src/mainboard/kontron/mal10/carriers/t10-tni/gpio.c:
https://review.coreboot.org/c/coreboot/+/39133/39/src/mainboard/kontron/mal1...
PS39, Line 6: static const struct pad_config gpio_table[] = {
Just curious, is there a specific reason for having that in gpio. […]
gpio.h contains macros that are not included in gpio_defs.h. I would not like to combine this with gpio config and also, it would be better when new definitions need to be added.
I saw some examples of boards and decided to repeat it.
https://review.coreboot.org/c/coreboot/+/39133/24/src/mainboard/kontron/mal1...
File src/mainboard/kontron/mal10/variants/mal10/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39133/24/src/mainboard/kontron/mal1...
PS24, Line 108: chip drivers/crb
It's indeed the fTPM
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8432e10396f77eb05a71af1ccaaa4437a2e43ea
Gerrit-Change-Number: 39133
Gerrit-PatchSet: 41
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 16 Aug 2020 15:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment