Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/86274?usp=email )
Change subject: mb/google/fatcat: Set frequency and gears for SaGv work points
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/86274/comment/bc72209c_8b16fb13?usp... :
PS4, Line 37: register "sagv_gear[0]" = "4"
can you please chip.h enum for defining the Gear selection SAGV points ?
```
enum {
GEAR_AUTO,
GEAR_1,
GEAR_2,
GEAR_3,
GEAR_4,
} SAGV_GEAR_SELECTION_POINTS
```
but looks like SaGv gear point values defined in vendorcode needs an update
https://github.com/coreboot/coreboot/blob/main/src/vendorcode/intel/fsp/fsp2...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86274?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I315fcac387680df9312880120b7e6d33bded38e0
Gerrit-Change-Number: 86274
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 05 Feb 2025 05:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No