Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 )
Change subject: security/intel/cbnt: Add logging ......................................................................
Patch Set 3:
(9 comments)
File src/security/intel/cbnt/logging.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/80d8d2f7_2d4a6f81 PS3, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/346677ac_c247af10 PS3, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/c7516640_e75ec60a PS3, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/b35173fe_57b9dabe PS3, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/99d2cef8_93a6e25a PS3, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/97ca4484_ada16119 PS3, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/5c96f222_15ee1c97 PS3, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/6d967648_d13788c3 PS3, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/bd51d54e_1b009aab PS3, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW)