Change in coreboot[master]: src/soc/amd/common: Add Azalia support to HDA

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35274 )

Change subject: src/soc/amd/common: Add Azalia support to HDA
......................................................................

src/soc/amd/common: Add Azalia support to HDA

Let the mainboard decide whether to let coreboot load the verb table.

Change-Id: I8f05ac02f690a43ada470916f5292b83aeaa8a4f
Signed-off-by: Marshall Dawson 
---
M src/soc/amd/common/block/hda/hda.c
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35274/1

diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c
index df3dc5e..c24e32d 100644
--- a/src/soc/amd/common/block/hda/hda.c
+++ b/src/soc/amd/common/block/hda/hda.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ * Copyright (C) 2010-2019 Advanced Micro Devices, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,6 +17,7 @@
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
+#include <device/azalia_device.h>

static const unsigned short pci_device_ids[] = {
    PCI_DEVICE_ID_AMD_SB900_HDA,
@@ -37,7 +38,8 @@
 };

static const struct pci_driver hdaaudio_driver __pci_driver = {
-	.ops = &hda_audio_ops,
+	.ops = CONFIG(AZALIA_PLUGIN_SUPPORT) ?
+			&default_azalia_audio_ops : &hda_audio_ops,
    .vendor = PCI_VENDOR_ID_AMD,
    .devices = pci_device_ids,
 };

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35274 )

Change subject: src/soc/amd/common: Add Azalia support to HDA
......................................................................

Patch Set 2: Code-Review+2

[Marshall Dawson (Code Review)]

Hello Richard Spiegel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35274

to look at the new patch set (#4).

Change subject: src/soc/amd/common: Add Azalia support to HDA
......................................................................

src/soc/amd/common: Add Azalia support to HDA

Let the mainboard decide whether to let coreboot load the verb table.

Change-Id: I8f05ac02f690a43ada470916f5292b83aeaa8a4f
Signed-off-by: Marshall Dawson 
---
M src/soc/amd/common/block/hda/hda.c
1 file changed, 5 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35274/4

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35274 )

Change subject: src/soc/amd/common: Add Azalia support to HDA
......................................................................

Patch Set 4: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35274 )

Change subject: src/soc/amd/common: Add Azalia support to HDA
......................................................................

src/soc/amd/common: Add Azalia support to HDA

Let the mainboard decide whether to let coreboot load the verb table.

Change-Id: I8f05ac02f690a43ada470916f5292b83aeaa8a4f
Signed-off-by: Marshall Dawson 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35274
Reviewed-by: Martin Roth 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/common/block/hda/hda.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/soc/amd/common/block/hda/hda.c b/src/soc/amd/common/block/hda/hda.c
index 27510c3..c24e32d 100644
--- a/src/soc/amd/common/block/hda/hda.c
+++ b/src/soc/amd/common/block/hda/hda.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ * Copyright (C) 2010-2019 Advanced Micro Devices, Inc.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -16,6 +16,8 @@
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
+#include <device/pci_ops.h>
+#include <device/azalia_device.h>

static const unsigned short pci_device_ids[] = {
    PCI_DEVICE_ID_AMD_SB900_HDA,
@@ -36,7 +38,8 @@
 };

static const struct pci_driver hdaaudio_driver __pci_driver = {
-	.ops = &hda_audio_ops,
+	.ops = CONFIG(AZALIA_PLUGIN_SUPPORT) ?
+			&default_azalia_audio_ops : &hda_audio_ops,
    .vendor = PCI_VENDOR_ID_AMD,
    .devices = pci_device_ids,
 };