Attention is currently required from: Patrick Rudolph, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78827?usp=email )
Change subject: sb/intel/bd82x6x/early_usb: Print error for invalid USB setting ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78827/comment/08cecbe3_e16a89c6 : PS8, Line 15: Tested: Lenovo X220 still boots. Isn't this a laptop? This change should be a no-op for mobile PCHs.
File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/c/coreboot/+/78827/comment/d0419463_625608b7 : PS8, Line 28: if (!pch_is_mobile() && portmap[i].current == 0) { We may want to skip complaining about disabled ports. If we still want to make sure the current index is not reserved, we need to fall back to any other value that is supported.
https://review.coreboot.org/c/coreboot/+/78827/comment/9cc36c53_dd25ac08 : PS8, Line 29: Consult the OEM for correct settings As most Sandy/Ivy Bridge ports are retrofits (people add coreboot support without OEM involvement), I think the following would be much more helpful:
``` /* * Note for developers: You can fix this by re-running autoport on * vendor firmware and then updating portmap currents accordingly. * If that is not possible, another option is to choose a non-zero * current setting. In either case, please test all the USB ports. */ ```