Change in coreboot[master]: soc/amd/common/block/sata: Fix the conditional to include sata.c

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

27 Apr 2020 27 Apr '20

7:54 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the conditional to include sata.c ......................................................................

soc/amd/common/block/sata: Fix the conditional to include sata.c

sata.c was being added to ramstage based on the selection of CONFIG_SOC_AMD_COMMON_BLOCK_HDA which is not correct. This change fixes the error by including sata.c based on selection of CONFIG_SOC_AMD_COMMON_BLOCK_SATA.

BUG=b:153858769

Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/sata/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/40766/1

diff --git a/src/soc/amd/common/block/sata/Makefile.inc b/src/soc/amd/common/block/sata/Makefile.inc index 59b99eb..3ca2a89 100644 --- a/src/soc/amd/common/block/sata/Makefile.inc +++ b/src/soc/amd/common/block/sata/Makefile.inc @@ -1 +1 @@ -ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_HDA) += sata.c +ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_SATA) += sata.c

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Paul Menzel (Code Review)

28 Apr 28 Apr

10 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the conditional to include sata.c ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/40766/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40766/1//COMMIT_MSG@7 PS1, Line 7: conditional condition

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 13:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:21 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40766

to look at the new patch set (#2).

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

soc/amd/common/block/sata: Fix the condition to include sata.c

BUG=b:153858769

Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/sata/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/40766/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:42 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 19:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

4:46 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 19:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:51 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40766/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40766/1//COMMIT_MSG@7 PS1, Line 7: conditional

...

condition

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 19:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

5:14 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

Patch Set 2: Code-Review+2

Oops

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 28 Apr 2020 20:14:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:56 p.m.

New subject: Change in coreboot[master]: soc/amd/common/block/sata: Fix the condition to include sata.c

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40766 )

Change subject: soc/amd/common/block/sata: Fix the condition to include sata.c ......................................................................

soc/amd/common/block/sata: Fix the condition to include sata.c

BUG=b:153858769

Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40766 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/sata/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/40766 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d23e5817872ddbb3d8d4f7dcabbaafcee4d51f4 Gerrit-Change-Number: 40766 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1820

days inactive

1821

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
Angel Pons (Code Review)
Furquan Shaikh (Code Review)
HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)