HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38653 )
Change subject: util: Fix typos ......................................................................
util: Fix typos
Change-Id: Ia405384211aa53ac089a99ecd31acc25effdb71e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/amdfwtool/amdfwtool.c M util/cbmem/cbmem.c M util/ifdtool/ifdtool.c 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/38653/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index d5c63de..522d332 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1439,7 +1439,7 @@
integrate_firmwares(&ctx, amd_romsig, amd_fw_table);
- ctx.current = ALIGN(ctx.current, 0x10000U); /* todo: is necessary? */ + ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is necessary? */
if (multi) { /* Do 2nd PSP directory followed by 1st */ diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index ca6a2f4..f8da7da 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -258,7 +258,7 @@ * passed in memory offset. Could be called recursively in case a forwarding * entry is found. * - * Returns pointer to a memory buffer containg the timestamp table or zero if + * Returns pointer to a memory buffer containing the timestamp table or zero if * none found. */
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 0b6b210..fb3fd89 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -631,11 +631,11 @@
static void dump_jid(uint32_t jid) { - printf(" SPI Componend Vendor ID: 0x%02x\n", + printf(" SPI Component Vendor ID: 0x%02x\n", jid & 0xff); - printf(" SPI Componend Device ID 0: 0x%02x\n", + printf(" SPI Component Device ID 0: 0x%02x\n", (jid >> 8) & 0xff); - printf(" SPI Componend Device ID 1: 0x%02x\n", + printf(" SPI Component Device ID 1: 0x%02x\n", (jid >> 16) & 0xff); }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38653 )
Change subject: util: Fix typos ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38653/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/38653/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1442: is necessary is *it* necessary?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38653 )
Change subject: util: Fix typos ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38653/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/38653/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1442: is necessary
is *it* necessary?
Done in CB:38944
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38653 )
Change subject: util: Fix typos ......................................................................
util: Fix typos
Change-Id: Ia405384211aa53ac089a99ecd31acc25effdb71e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38653 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/amdfwtool/amdfwtool.c M util/ifdtool/ifdtool.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index d5c63de..522d332 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1439,7 +1439,7 @@
integrate_firmwares(&ctx, amd_romsig, amd_fw_table);
- ctx.current = ALIGN(ctx.current, 0x10000U); /* todo: is necessary? */ + ctx.current = ALIGN(ctx.current, 0x10000U); /* TODO: is necessary? */
if (multi) { /* Do 2nd PSP directory followed by 1st */ diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 2bf2f4d..d89e77d 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -631,11 +631,11 @@
static void dump_jid(uint32_t jid) { - printf(" SPI Componend Vendor ID: 0x%02x\n", + printf(" SPI Component Vendor ID: 0x%02x\n", jid & 0xff); - printf(" SPI Componend Device ID 0: 0x%02x\n", + printf(" SPI Component Device ID 0: 0x%02x\n", (jid >> 8) & 0xff); - printf(" SPI Componend Device ID 1: 0x%02x\n", + printf(" SPI Component Device ID 1: 0x%02x\n", (jid >> 16) & 0xff); }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)