Change in coreboot[master]: soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax
V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41954 )
Change subject: soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax ......................................................................
soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax
This change updates camera_clock_ctl.asl to use ASL2.0 syntax. This increases the readability of the ASL code.
TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.
Change-Id: I76ec29210ecdde728ce55531d2b6657be87ce9da Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/41954/1
diff --git a/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl b/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl index 3d31502..d76cb5d 100644 --- a/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl +++ b/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl @@ -11,7 +11,7 @@
/* IsCLK PCH base register for clock settings */ Name (ICKB, 0) - Store (PCRB (PID_ISCLK) + R_ICLK_PCR_CAMERA1, ICKB) + ICKB = PCRB (PID_ISCLK) + R_ICLK_PCR_CAMERA1
/* * Arg0 : Clock Number
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41954 )
Change subject: soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41954 )
Change subject: soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax ......................................................................
soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax
This change updates camera_clock_ctl.asl to use ASL2.0 syntax. This increases the readability of the ASL code.
TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.
Change-Id: I76ec29210ecdde728ce55531d2b6657be87ce9da Signed-off-by: V Sowmya v.sowmya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41954 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl b/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl index 3d31502..d76cb5d 100644 --- a/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl +++ b/src/soc/intel/jasperlake/acpi/camera_clock_ctl.asl @@ -11,7 +11,7 @@
/* IsCLK PCH base register for clock settings */ Name (ICKB, 0) - Store (PCRB (PID_ISCLK) + R_ICLK_PCR_CAMERA1, ICKB) + ICKB = PCRB (PID_ISCLK) + R_ICLK_PCR_CAMERA1
/* * Arg0 : Clock Number
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41954 )
Change subject: soc/intel/jasperlake: Update camera_clock_ctl.asl to ASL2.0 syntax ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4652 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4651 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4650 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4649
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)
-
V Sowmya (Code Review)