Change in coreboot[master]: mb/google/glados: Drop TPM PIRQ

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62444 )

Change subject: mb/google/glados: Drop TPM PIRQ
......................................................................

mb/google/glados: Drop TPM PIRQ

The Infineon TPM 1.2 used on glados boards doesn't use a PIRQ;
Linux only works with 'tpm.tis_interrupts=0" and Windows fails to
init the TPM citing a lack of available resources. With the PIRQ
removed, both Linux and Windows are happy / the TPM is available
for use.

Test: build/boot Linux 5.16.x and Windows 11 on google/chell

Change-Id: I544695505291bbebe062df636cc8ddd139c08c2b
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62444
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
M src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
M src/mainboard/google/glados/variants/cave/include/variant/gpio.h
M src/mainboard/google/glados/variants/chell/include/variant/gpio.h
M src/mainboard/google/glados/variants/glados/include/variant/gpio.h
M src/mainboard/google/glados/variants/lars/include/variant/gpio.h
M src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
8 files changed, 7 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index 68e4f71..3a1f38b 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -113,10 +113,6 @@
 config OVERRIDE_DEVICETREE
    default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"

-config TPM_PIRQ
-	hex
-	default 0x18  # GPP_E0_IRQ
-
 config INCLUDE_NHLT_BLOBS
    bool "Include blobs for audio."
    select NHLT_DMIC_2CH
diff --git a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
index 758b7cc..135768a 100644
--- a/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/asuka/include/variant/gpio.h
@@ -143,7 +143,7 @@
 /* ITCH_SPI_D2 */	PAD_NC(GPP_D21, NONE),
 /* ITCH_SPI_D3 */	PAD_NC(GPP_D22, NONE),
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SPI_TPM_IRQ */	PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST),
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SSD_PEDET */		PAD_NC(GPP_E2, NONE),
 /* AUDIO_DB_ID */	PAD_CFG_GPI_GPIO_DRIVER(GPP_E3, NONE, DEEP),
diff --git a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
index fe31102..8003dbe 100644
--- a/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/caroline/include/variant/gpio.h
@@ -152,7 +152,7 @@
 /* TS_SPI1_IO2 */	PAD_NC(GPP_D21, NONE),
 /* TS_SPI1_IO3 */	PAD_CFG_GPO(GPP_D22, 1, DEEP), /* I2S2 BUFFER */
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SATAXPCI0 */		PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST), /* TPM_PIRQ_L */
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SATAXPCIE2 */	PAD_NC(GPP_E2, NONE),
 /* CPU_GP0 */		PAD_NC(GPP_E3, NONE),
diff --git a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
index e96a78a..b908348 100644
--- a/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/cave/include/variant/gpio.h
@@ -148,7 +148,7 @@
 /* TS_SPI_IO2 */	PAD_NC(GPP_D21, NONE),
 /* TS_SPI_IO3 */	PAD_NC(GPP_D22, NONE),
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SATAXPCI0 */		PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST), /* TPM_PIRQ_L */
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SATAXPCIE2 */	PAD_NC(GPP_E2, NONE),
 /* CPU_GP0 */		PAD_CFG_GPI_GPIO_DRIVER(GPP_E3, NONE, DEEP), /* AUDIO_DB_ID */
diff --git a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
index 3260472..d1215e6 100644
--- a/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/chell/include/variant/gpio.h
@@ -142,7 +142,7 @@
 /* SPI1_IO2 */		PAD_CFG_GPO(GPP_D21, 0, DEEP),
 /* SPI1_IO3 */		PAD_CFG_GPO(GPP_D22, 0, DEEP), /* I2S2 BUFFER */
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SATAXPCI0 */		PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST), /* TPM_PIRQ_L */
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SATAXPCIE2 */	PAD_NC(GPP_E2, NONE),
 /* CPU_GP0 */		PAD_CFG_GPO(GPP_E3, 1, DEEP), /* TOUCHSCREEN_RST_L */
diff --git a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
index b812fb7..8baecab 100644
--- a/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/glados/include/variant/gpio.h
@@ -145,7 +145,7 @@
    		/* GPP_D21 */
    		/* GPP_D22 */
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SATAXPCI0 */		PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, DEEP), /* TPM_PIRQ_L */
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	/* GPP_E1 */
 /* SATAXPCIE2 */	/* GPP_E2 */
 /* CPU_GP0 */		/* GPP_E3 */
diff --git a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
index 7cf56aa..5ff059b 100644
--- a/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/lars/include/variant/gpio.h
@@ -138,7 +138,7 @@
 /* ITCH_SPI_D2 */	PAD_NC(GPP_D21, NONE),
 /* ITCH_SPI_D3 */	PAD_NC(GPP_D22, NONE),
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SPI_TPM_IRQ */	PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST),
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SSD_PEDET */		PAD_NC(GPP_E2, NONE),
 /* CPU_GP0 */		PAD_NC(GPP_E3, NONE),
diff --git a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
index 10291b0..f208a27 100644
--- a/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
+++ b/src/mainboard/google/glados/variants/sentry/include/variant/gpio.h
@@ -146,7 +146,7 @@
 /* ITCH_SPI_D2 */	PAD_NC(GPP_D21, NONE),
 /* ITCH_SPI_D3 */	PAD_NC(GPP_D22, NONE),
 /* I2S_MCLK */		PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
-/* SPI_TPM_IRQ */	PAD_CFG_GPI_APIC_HIGH(GPP_E0, NONE, PLTRST),
+/* SPI_TPM_IRQ */	PAD_NC(GPP_E0, NONE),
 /* SATAXPCIE1 */	PAD_NC(GPP_E1, NONE),
 /* SSD_PEDET */		PAD_NC(GPP_E2, NONE),
 /* AUDIO_DB_ID */	PAD_CFG_GPI_GPIO_DRIVER(GPP_E3, NONE, DEEP),