EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40414 )
Change subject: lib/spd_bin: add get_spd_sn function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40414/3/src/soc/intel/common/block/... File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40414/3/src/soc/intel/common/block/... PS3, Line 95: if (!dimm_preset(addr)) { Please add add check for non-zero like #77. If addr is 0, smbus will return 0xff.