Change in ...coreboot[master]: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()

[Nico Huber (Code Review)]

Hello HAOUAS Elyes, Julius Werner, Angel Pons, Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32227

to review the following change.

Change subject: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()
......................................................................

nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()

We decided to not care about compile-time errors. So drop the comment,
the code was updated already.

Change-Id: Ib115fa6e2c48bfde7f67c327d42b3fe0e7af8c1f
Signed-off-by: Nico Huber 
---
M src/northbridge/amd/pi/agesawrapper.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/32227/1

diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c
index 1cc7b7c..cda5e01 100644
--- a/src/northbridge/amd/pi/agesawrapper.c
+++ b/src/northbridge/amd/pi/agesawrapper.c
@@ -125,8 +125,6 @@
    AmdCreateStruct (&AmdParamStruct);
    PostParams = (AMD_POST_PARAMS *)AmdParamStruct.NewStructPtr;

-	// Do not use IS_ENABLED here.  CONFIG_GFXUMA should always have a value.  Allow
-	// the compiler to flag the error if CONFIG_GFXUMA is not set.
    PostParams->MemConfig.UmaMode = CONFIG(GFXUMA) ? UMA_AUTO : UMA_NONE;
    PostParams->MemConfig.UmaSize = 0;
    PostParams->MemConfig.BottomIo = (UINT16)

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32227 )

Change subject: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()
......................................................................

Patch Set 1: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32227 )

Change subject: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32227 )

Change subject: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()
......................................................................

Patch Set 1: Code-Review+1

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32227 )

Change subject: nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()
......................................................................

nb/amd/pi/agesawrapper: Drop stale comment about IS_ENABLED()

We decided to not care about compile-time errors. So drop the comment,
the code was updated already.

Change-Id: Ib115fa6e2c48bfde7f67c327d42b3fe0e7af8c1f
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32227
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Paul Menzel 
---
M src/northbridge/amd/pi/agesawrapper.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c
index 1cc7b7c..cda5e01 100644
--- a/src/northbridge/amd/pi/agesawrapper.c
+++ b/src/northbridge/amd/pi/agesawrapper.c
@@ -125,8 +125,6 @@
    AmdCreateStruct (&AmdParamStruct);
    PostParams = (AMD_POST_PARAMS *)AmdParamStruct.NewStructPtr;

-	// Do not use IS_ENABLED here.  CONFIG_GFXUMA should always have a value.  Allow
-	// the compiler to flag the error if CONFIG_GFXUMA is not set.
    PostParams->MemConfig.UmaMode = CONFIG(GFXUMA) ? UMA_AUTO : UMA_NONE;
    PostParams->MemConfig.UmaSize = 0;
    PostParams->MemConfig.BottomIo = (UINT16)