Federico Amedeo Izzo has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
coreboot logs the time spent printing, it doesn't seem to be that high. […]
You both were right, disabling `CONFIG_CONSOLE_SERIAL` reduced the boot time to 1.895s, which is not much lower, but still lower.
This time on the second commit i avoided the MRC cache by disabling it in the config `CONFIG_CACHE_MRC_SETTINGS=n`, as this board always reboots itself on first boot after flashing and reconnecting power, so I was missing the boot without MRC cache.
Thanks for all the feedback, It's been a pleasure contributing this port!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82010?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9414eb742b6b90459e010b038c1994537e9801a5
Gerrit-Change-Number: 82010
Gerrit-PatchSet: 17
Gerrit-Owner: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Brandon Weeks
bweeks@google.com
Gerrit-Comment-Date: Sun, 30 Jun 2024 15:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Federico Amedeo Izzo
federico@izzo.pro