Change in coreboot[master]: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
[RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources
This would skip attempting to clear regions like TSEG, GTT, IGD, ...
Change-Id: I2ac9d53f2c405100d21720ec0fcd1b498a028416 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/security/memory/memory_clear.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/47160/1
diff --git a/src/security/memory/memory_clear.c b/src/security/memory/memory_clear.c index 557125d..411af73 100644 --- a/src/security/memory/memory_clear.c +++ b/src/security/memory/memory_clear.c @@ -67,7 +67,7 @@
memranges_init(&mem, IORESOURCE_MEM | IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED | - IORESOURCE_CACHEABLE, + IORESOURCE_CACHEABLE | IORESOURCE_RESERVE, IORESOURCE_MEM | IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED | IORESOURCE_CACHEABLE,
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG@10 PS1, Line 10: Any idea, what commit introduced the regression?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG@10 PS1, Line 10:
Any idea, what commit introduced the regression?
Such regions shouldn't be marked as cacheable, so the error (or difference to tested systems) is likely somewhere in the chipset code.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47160/1//COMMIT_MSG@10 PS1, Line 10:
Such regions shouldn't be marked as cacheable, so the error (or difference […]
reserved_ram_resource() is used for some of these regions which is not correct.
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
Abandoned
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47160 )
Change subject: [RFC]security/memory/memory_clear: Skip IORESOURCE_RESERVE resources ......................................................................
Patch Set 1:
https://review.coreboot.org/c/coreboot/+/47174 should fix things on pineview
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)