[M] Change in coreboot[master]: mb/asus/p8x7x-series: Refactor mainboard_get_spd() - coreboot-gerrit

2 Mar 2023


      Attention is currently required from: Felix Singer, Arthur Heymans, Keith Hui, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
...
All, let's start that weakness discussion right now. […]
Can't recall, sorry. In this case, it's likely that no override will be needed in the future, so feel free to leave out the __weak for now. Even if there's a board with 2 DIMM slots, it would still work: it just tries reading two SPDs that are always not present. It would only be a problem if the board uses a non-standard DIMM slot mapping, e.g. Asus P8H61-M PRO CM6630 (in asus/h61m-series).
TL;DR: Option 3 seems reasonable.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 02 Mar 2023 09:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui buurin@gmail.com
Gerrit-MessageType: comment