Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Arthur Heymans, Jianjun Wang.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63494 )
Change subject: coreboot_tables: Replace 'struct lb_uint64' with lb_uint64_t
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Sorry, forgot that earlier... but we should do the same thing on the libpayload side as well. (The struct cb_uint64 in libpayload should technically be compatible to the lb_uint64_t in coreboot on little-endian systems, but it's still not exactly clean to just rely on that.)
In fact, since we now have commonlib/bsd accessible in libpayload, this would probably be a good opportunity to just combine the two separate definitions of these tables into one now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6b037e4403a8000625f4a5fb8d20311fe76200a
Gerrit-Change-Number: 63494
Gerrit-PatchSet: 5
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 19:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment