[S] Change in coreboot[master]: Revert "soc/intel/common/block/cse/Kconfig: Remove unused symbols"

[Reka Norman (Code Review)]

Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Nick Vaccaro, Nico Huber, Paul Menzel, Subrata Banik.

Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76719?usp=email )

Change subject: Revert "soc/intel/common/block/cse/Kconfig: Remove unused symbols"
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> I wouldn't block this fixe.

I agree this is a larger discussion which shouldn't block the revert.

I'm happy to make changes in a follow up, but I don't understand exactly what you're suggesting. The Kconfigs need to be upstream because they're used in an upstream Makefile. Are you suggesting the Makefile, etc shouldn't be upstream either? It seems better to me to have as much upstream as possible and only the binaries themselves private. One of the motivations for the stitching tools was to give coreboot more visibility into the CSE layout instead of using a pre-stitched CSE binary (see CB:57353 for more details).

It's also a common pattern to have private binaries incorporated into the upstream build system (descriptor, FSP binaries, VBTs, etc). Whether or not we should do that is a much larger topic which I'm sure has been discussed many times.